[core] Add dry_run parameters to purge_files Procedure and show the …#5342
Merged
JingsongLi merged 4 commits intoapache:masterfrom Mar 27, 2025
Merged
Conversation
…list of deleted directories.
LinMingQiang
changed the title
xuzifu666
reviewed
Mar 25, 2025
Member
xuzifu666
left a comment
xuzifu666
left a comment
There was a problem hiding this comment.
Make sense for avoiding the risk from delete files by dry_run, overall LGTM and left minor comments.
...paimon-flink-common/src/main/java/org/apache/paimon/flink/procedure/PurgeFilesProcedure.java
Outdated
Show resolved
Hide resolved
...paimon-flink-common/src/main/java/org/apache/paimon/flink/procedure/PurgeFilesProcedure.java
Outdated
Show resolved
Hide resolved
...paimon-flink-common/src/main/java/org/apache/paimon/flink/procedure/PurgeFilesProcedure.java
Outdated
Show resolved
Hide resolved
Contributor
yunfengzhou-hub
left a comment
yunfengzhou-hub
left a comment
There was a problem hiding this comment.
Thanks for the update. The Flink parts LGTM except the following comment.
Contributor
|
+1 |
danzhewuju
pushed a commit
to danzhewuju/paimon
that referenced
this pull request
Mar 31, 2025
…e list of deleted directories (apache#5342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…list of deleted directories.
Purpose
Linked issue: close #5337
Tests
API and Format
Documentation