[python/hotfix] Fix zstd manifest decompression error on Python 3.6 #6982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We should add java & python e2e for 3.6 too. |
Contributor
Author
👌 |
XiaoHongbo-Hope
changed the title
added 2 commits
January 8, 2026 22:24
Contributor
Author
When I tried to enable e2e case for py36, some cases failed. Then I only add current case for py36 in this PR, will create another PR to fix other cases in py36 |
JingsongLi
reviewed
Jan 8, 2026
paimon-python/dev/run_mixed_tests.sh
Outdated
| } | ||
|
|
||
| # Function to run zstd manifest e2e test | ||
| run_zstd_manifest_test() { |
Contributor
There was a problem hiding this comment.
You don't need to create this, by default, manifest is compressed by zstd.
added 4 commits
January 9, 2026 00:30
JingsongLi
reviewed
Jan 9, 2026
|
|
||
| @Test | ||
| @EnabledIfSystemProperty(named = "run.e2e.tests", matches = "true") | ||
| @DisabledIfSystemProperty(named = "python.version", matches = "3.6") |
Contributor
Author
There was a problem hiding this comment.
Why disable for 3.6?
compatible issue in pk table for py36, will create another PR to fix it.
JingsongLi
reviewed
Jan 9, 2026
|
|
||
| @Test | ||
| @EnabledIfSystemProperty(named = "run.e2e.tests", matches = "true") | ||
| @DisabledIfSystemProperty(named = "python.version", matches = "3.6") |
Contributor
Author
There was a problem hiding this comment.
Why disable for 3.6?
py36 does not have pylance dependency
added 2 commits
January 9, 2026 12:54
Contributor
|
Thanks @XiaoHongbo-Hope , looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation