Update example in shredding spec #478
Merged
wgtmac merged 1 commit intoapache:masterfrom Jan 15, 2025
Merged
Conversation
Contributor
Author
cashmand
approved these changes
Jan 10, 2025
cashmand
left a comment
cashmand
left a comment
There was a problem hiding this comment.
Agreed, I think the old example was mistaken.
Contributor
Author
|
cc @wgtmac @emkornfield Can you help merge this change to avoid confusion? |
wgtmac
approved these changes
Jan 15, 2025
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Seems the example included in shredding spec is not correct. 123 in row 3 and 4 can be shredded. Correct them to avoid confusion.
Do these changes have PoC implementations?
Closes #477