PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #240

THausherr · THausherr · commit 0e541824ded5 · 2025-08-30T18:51:28.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1928131 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/COSArrayList.java b/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/COSArrayList.java
@@ -475,11 +475,12 @@ public E set(int index, E element)
         }
         else
         {
+            COSBase cosObject = ((COSObjectable) element).getCOSObject();
             if( parentDict != null && index == 0 )
             {
-                parentDict.setItem( dictKey, ((COSObjectable)element).getCOSObject() );
+                parentDict.setItem(dictKey, cosObject);
             }
-            array.set( index, ((COSObjectable)element).getCOSObject() );
+            array.set(index, cosObject);
         }
         return actual.set( index, element );
     }

Original file line number	Diff line number	Diff line change
`@@ -475,11 +475,12 @@ public E set(int index, E element)`
`475`	`475`	`}`
`476`	`476`	`else`
`477`	`477`	`{`
	`478`	`+ COSBase cosObject = ((COSObjectable) element).getCOSObject();`
`478`	`479`	`if( parentDict != null && index == 0 )`
`479`	`480`	`{`
`480`		`- parentDict.setItem( dictKey, ((COSObjectable)element).getCOSObject() );`
	`481`	`+ parentDict.setItem(dictKey, cosObject);`
`481`	`482`	`}`
`482`		`- array.set( index, ((COSObjectable)element).getCOSObject() );`
	`483`	`+ array.set(index, cosObject);`
`483`	`484`	`}`
`484`	`485`	`return actual.set( index, element );`
`485`	`486`	`}`