PDFBOX-5660: optimize, as suggested by Valery Bokov, closes #362

THausherr · THausherr · commit 5c98a59eaef0 · 2025-12-02T20:06:46.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1930203 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/fontbox/src/main/java/org/apache/fontbox/ttf/gsub/GsubWorkerForDevanagari.java b/fontbox/src/main/java/org/apache/fontbox/ttf/gsub/GsubWorkerForDevanagari.java
@@ -239,7 +239,7 @@ private List<Integer> getBeforeHalfGlyphIds()
 
     private List<Integer> getRephGlyphIds()
     {
-        List<Integer> result = new ArrayList<>();
+        List<Integer> result = new ArrayList<>(REPH_CHARS.length);
         for (char character : REPH_CHARS)
         {
             result.add(getGlyphId(character));
@@ -249,7 +249,7 @@ private List<Integer> getRephGlyphIds()
 
     private List<Integer> getBeforeRephGlyphIds()
     {
-        List<Integer> glyphIds = new ArrayList<>();
+        List<Integer> glyphIds = new ArrayList<>(BEFORE_REPH_CHARS.length);
         for (char character : BEFORE_REPH_CHARS)
         {
             glyphIds.add(getGlyphId(character));
diff --git a/fontbox/src/main/java/org/apache/fontbox/ttf/gsub/GsubWorkerForGujarati.java b/fontbox/src/main/java/org/apache/fontbox/ttf/gsub/GsubWorkerForGujarati.java
@@ -238,7 +238,7 @@ private List<Integer> getBeforeHalfGlyphIds()
 
     private List<Integer> getRephGlyphIds()
     {
-        List<Integer> result = new ArrayList<>();
+        List<Integer> result = new ArrayList<>(REPH_CHARS.length);
         for (char character : REPH_CHARS)
         {
             result.add(getGlyphId(character));
@@ -248,7 +248,7 @@ private List<Integer> getRephGlyphIds()
 
     private List<Integer> getBeforeRephGlyphIds()
     {
-        List<Integer> glyphIds = new ArrayList<>();
+        List<Integer> glyphIds = new ArrayList<>(BEFORE_REPH_CHARS.length);
         for (char character : BEFORE_REPH_CHARS)
         {
             glyphIds.add(getGlyphId(character));

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ private List<Integer> getBeforeHalfGlyphIds()`
`239`	`239`
`240`	`240`	`private List<Integer> getRephGlyphIds()`
`241`	`241`	`{`
`242`		`- List<Integer> result = new ArrayList<>();`
	`242`	`+ List<Integer> result = new ArrayList<>(REPH_CHARS.length);`
`243`	`243`	`for (char character : REPH_CHARS)`
`244`	`244`	`{`
`245`	`245`	`result.add(getGlyphId(character));`
`@@ -249,7 +249,7 @@ private List<Integer> getRephGlyphIds()`
`249`	`249`
`250`	`250`	`private List<Integer> getBeforeRephGlyphIds()`
`251`	`251`	`{`
`252`		`- List<Integer> glyphIds = new ArrayList<>();`
	`252`	`+ List<Integer> glyphIds = new ArrayList<>(BEFORE_REPH_CHARS.length);`
`253`	`253`	`for (char character : BEFORE_REPH_CHARS)`
`254`	`254`	`{`
`255`	`255`	`glyphIds.add(getGlyphId(character));`
Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ private List<Integer> getBeforeHalfGlyphIds()`
`238`	`238`
`239`	`239`	`private List<Integer> getRephGlyphIds()`
`240`	`240`	`{`
`241`		`- List<Integer> result = new ArrayList<>();`
	`241`	`+ List<Integer> result = new ArrayList<>(REPH_CHARS.length);`
`242`	`242`	`for (char character : REPH_CHARS)`
`243`	`243`	`{`
`244`	`244`	`result.add(getGlyphId(character));`
`@@ -248,7 +248,7 @@ private List<Integer> getRephGlyphIds()`
`248`	`248`
`249`	`249`	`private List<Integer> getBeforeRephGlyphIds()`
`250`	`250`	`{`
`251`		`- List<Integer> glyphIds = new ArrayList<>();`
	`251`	`+ List<Integer> glyphIds = new ArrayList<>(BEFORE_REPH_CHARS.length);`
`252`	`252`	`for (char character : BEFORE_REPH_CHARS)`
`253`	`253`	`{`
`254`	`254`	`glyphIds.add(getGlyphId(character));`