Skip to content

Commit d3bf7a4

Browse files
committed
PDFBOX-5660: close input, as suggested by Valery Bokov; refactor; closes #311
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1929505 13f79535-47bb-0310-9956-ffa450edef68
1 parent 746cf4e commit d3bf7a4

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,12 @@
2121

2222
package org.apache.xmpbox;
2323

24-
import static org.junit.jupiter.api.Assertions.assertFalse;
25-
24+
import java.io.IOException;
2625
import java.io.InputStream;
2726
import java.util.stream.Stream;
2827

28+
import static org.junit.jupiter.api.Assertions.assertFalse;
29+
2930
import org.apache.xmpbox.xml.DomXmpParser;
3031
import org.apache.xmpbox.xml.XmpParsingException;
3132
import org.junit.jupiter.params.ParameterizedTest;
@@ -46,13 +47,14 @@ static Stream<String> initializeParameters()
4647

4748
@ParameterizedTest
4849
@MethodSource("initializeParameters")
49-
void main(String path) throws XmpParsingException
50+
void main(String path) throws XmpParsingException, IOException
5051
{
51-
InputStream is = this.getClass().getResourceAsStream(path);
52-
53-
DomXmpParser builder = new DomXmpParser();
54-
XMPMetadata rxmp = builder.parse(is);
55-
// ensure basic parsing was OK
56-
assertFalse(rxmp.getAllSchemas().isEmpty());
52+
try (InputStream is = this.getClass().getResourceAsStream(path))
53+
{
54+
DomXmpParser builder = new DomXmpParser();
55+
XMPMetadata rxmp = builder.parse(is);
56+
// ensure basic parsing was OK
57+
assertFalse(rxmp.getAllSchemas().isEmpty());
58+
}
5759
}
5860
}

0 commit comments

Comments
 (0)