Avoid deprecated code (that will be removed in pekko 2.0.0) #803
Conversation
readability import temp compile workaround Update ConnectionTestApp.scala Update ConnectionTestApp.scala
Update HttpServerBluePrint.scala
| Source.actorRef[(HttpRequest, Int)](10000, OverflowStrategy.dropNew).buffer(20000, OverflowStrategy.fail) | ||
| Source.queue[(HttpRequest, Int)](10000) | ||
| .buffer(20000, OverflowStrategy.fail) |
There was a problem hiding this comment.
Is this a change in behavior (dropNew -> fail)? Seems fine for a test app though.
There was a problem hiding this comment.
Would https://pekko.apache.org/japi/pekko/1.2/org/apache/pekko/stream/OverflowStrategy.html#backpressure() make sense? OverflowStrategy.dropNew is being removed (already deprecated in 1.x).
There was a problem hiding this comment.
Would https://pekko.apache.org/japi/pekko/1.2/org/apache/pekko/stream/OverflowStrategy.html#backpressure() make sense? OverflowStrategy.dropNew is being removed (already deprecated in 1.x).
TBH I'm not sure what this means in practice here - would that mean 'offer' would give a return value indicating the backpressure? I think fail is probably a fine choice.
3 participants
splitting out some changes from #779