Skip to content

use ByteString.asInputStream #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use ByteString.asInputStream #820

wants to merge 1 commit into from

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented Oct 3, 2025 •
edited
Loading

  • see Twitter Decoder cannot handle all InputStream implementations #553 for why we need the workaround for ByteString.ByteStrings
  • I tried wrapping the InputStream as a BufferedInputStream but that wasn't enough for Twitter HPack code
  • the existing code already compacts ByteString.ByteStrings anyway - not ideal but new code should be better for the other ByteString cases

@pjfanning pjfanning added this to the 2.0.0 milestone Oct 3, 2025
@jrudolph jrudolph mentioned this pull request Oct 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@pjfanning