Skip to content

TestSource/TestSink probe deprecated #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjfanning merged 1 commit into from
Nov 14, 2025
Merged

TestSource/TestSink probe deprecated #870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...re/src/test/scala/org/apache/pekko/http/impl/engine/client/HttpsProxyGraphStageSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,9 @@ class HttpsProxyGraphStageSpec extends PekkoSpecWithMaterializer {

val flowUnderTest = proxyGraphStage.join(proxyFlow)

val (source, sink) = TestSource.probe[ByteString]
val (source, sink) = TestSource[ByteString]()
.via(flowUnderTest)
.toMat(TestSink.probe)(Keep.both)
.toMat(TestSink())(Keep.both)
.run()

fn(source, flowInProbe, flowOutProbe, sink)
Expand Down
4 changes: 2 additions & 2 deletions http-core/src/test/scala/org/apache/pekko/http/impl/engine/ws/WebSocketIntegrationSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class WebSocketIntegrationSpec extends PekkoSpecWithMaterializer(

val (response, sink) = Http().singleWebSocketRequest(
WebSocketRequest("ws://127.0.0.1:" + myPort),
Flow.fromSinkAndSourceMat(TestSink.probe[Message], Source.empty)(Keep.left))
Flow.fromSinkAndSourceMat(TestSink[Message](), Source.empty)(Keep.left))

response.futureValue.response.status.isSuccess should ===(true)
sink
Expand Down Expand Up @@ -119,7 +119,7 @@ class WebSocketIntegrationSpec extends PekkoSpecWithMaterializer(
Tcp(system).outgoingConnection(new InetSocketAddress("localhost", myPort), halfClose = true)))(
Keep.both)
}(Keep.right)
.toMat(TestSink.probe[Message])(Keep.both)
.toMat(TestSink[Message]())(Keep.both)
.run()

response.futureValue.response.status.isSuccess should ===(true)
Expand Down
4 changes: 2 additions & 2 deletions http-core/src/test/scala/org/apache/pekko/http/scaladsl/GracefulTerminationSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ class GracefulTerminationSpec
// start reading the response
val responseEntity = r1.futureValue.entity.dataBytes
.via(Framing.delimiter(ByteString(","), 20))
.runWith(TestSink.probe[ByteString])(SystemMaterializer(clientSystem).materializer)
.runWith(TestSink[ByteString]())(SystemMaterializer(clientSystem).materializer)
responseEntity.requestNext().utf8String should ===("reply1")

val termination = serverBinding.terminate(hardDeadline = 1.second)
Expand Down Expand Up @@ -132,7 +132,7 @@ class GracefulTerminationSpec
// start reading the response
val response = r1.futureValue.entity.dataBytes
.via(Framing.delimiter(ByteString(","), 20))
.runWith(TestSink.probe[ByteString])
.runWith(TestSink[ByteString]())
response.requestNext().utf8String should ===("reply1")

try {
Expand Down
2 changes: 1 addition & 1 deletion http2-tests/src/test/scala/org/apache/pekko/http/impl/engine/http2/Http2ClientSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ class Http2ClientSpec extends PekkoSpecWithMaterializer("""
val chunksIn =
user.expectResponse()
.entity.asInstanceOf[Chunked]
.chunks.runWith(TestSink.probe[ChunkStreamPart](system.classicSystem))
.chunks.runWith(TestSink[ChunkStreamPart]()(system.classicSystem))
val data1 = ByteString("abcdef")
network.sendDATA(TheStreamId, endStream = false, data1)
chunksIn.request(2)
Expand Down
6 changes: 3 additions & 3 deletions ...2-tests/src/test/scala/org/apache/pekko/http/impl/engine/http2/Http2ServerDemuxSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ class Http2ServerDemuxSpec extends PekkoSpecWithMaterializer("""
(SettingIdentifier.SETTINGS_ENABLE_PUSH, 0))
val bidi = BidiFlow.fromGraph(new Http2ServerDemux(settings, initialRemoteSettings, upgraded = true))

val ((substreamProducer, (frameConsumer, frameProducer)), substreamConsumer) = TestSource.probe[Http2SubStream]
.viaMat(bidi.joinMat(Flow.fromSinkAndSourceMat(TestSink.probe[FrameEvent], TestSource.probe[FrameEvent])(
val ((substreamProducer, (frameConsumer, frameProducer)), substreamConsumer) = TestSource[Http2SubStream]()
.viaMat(bidi.joinMat(Flow.fromSinkAndSourceMat(TestSink[FrameEvent](), TestSource[FrameEvent]())(
Keep.both))(Keep.right))(Keep.both)
.toMat(TestSink.probe[Http2SubStream])(Keep.both)
.toMat(TestSink[Http2SubStream]())(Keep.both)
.run()

frameConsumer.request(1000)
Expand Down