exclude provided and optional dependencies from submission #1554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to use the dependabot security report for artifacts that actually come in as transitive dependencies for our users. The chance that an advisory for an optional/provided/test/built-time dependency actually impacts our build seems to small to justify the noise it adds. Fixes apache#1553
raboof
force-pushed
the
dependency-submission-ignore-provided-optional
branch
from
b5cd705 to
773cd41
Compare
Member
Author
|
Possibly we should make sure those get marked correctly as 'development' dependencies in sbt-dependency-submission (scalacenter/sbt-dependency-submission#234). Since we don't care about advisories in development dependencies, though, it still makes sense to exclude them here entirely. |
Member
Author
|
LOL this is actually a duplicate of my own earlier #1392 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to use the dependabot security report for artifacts that actually come in as transitive dependencies for our users. The chance that an advisory for an optional/provided/test/build-time dependency actually impacts our build seems to small to justify the noise it adds.
Fixes #1553