Fix Address ordering bug (mixed pekko/akka cluster)

[sadekmunawar]

This bug causes major issues when a cluster contains nodes using both "akka" and "pekko". It can be a significant obstacle when migrating from Akka to Pekko through a rolling upgrade, especially if the migration requires the cluster to run with mixed protocols for an extended period.

Due to this bug, the DistributedPubSubMediator fails to send messages to some registered nodes. In the DistributedPubSubMediator, node addresses are stored in a set. However, when set membership relies on the faulty addressOrdering method, set.contains returns false for some addresses that are actually in the set.

[He-Pin]

lgtm, thanks ,and this should be backport to older version too.

[pjfanning]

A test failed in Scala 3 run. Could be an intermittent issue that affects the test already.

[11-25 02:13:26.569] [info] - must deliver first message *** FAILED *** (8 seconds, 144 milliseconds)
[11-25 02:13:26.569] [info]   java.lang.AssertionError: assertion failed: timeout (6 seconds) during expectMsg while waiting for OnNext(d)
[11-25 02:13:26.569] [info]   at scala.runtime.Scala3RunTime$.assertFailed(Scala3RunTime.scala:8)
[11-25 02:13:26.569] [info]   at org.apache.pekko.testkit.TestKitBase.expectMsg_internal(TestKit.scala:472)
[11-25 02:13:26.569] [info]   at org.apache.pekko.testkit.TestKitBase.expectMsg(TestKit.scala:449)
[11-25 02:13:26.569] [info]   at org.apache.pekko.testkit.TestKitBase.expectMsg$(TestKit.scala:169)
[11-25 02:13:26.569] [info]   at org.apache.pekko.testkit.TestKit.expectMsg(TestKit.scala:982)
[11-25 02:13:26.569] [info]   at org.apache.pekko.stream.testkit.TestSubscriber$ManualProbe.expectNext(StreamTestKit.scala:523)
[11-25 02:13:26.569] [info]   at org.apache.pekko.remote.artery.SendQueueSpec.test$1$$anonfun$1(SendQueueSpec.scala:188)
[11-25 02:13:26.569] [info]   at org.apache.pekko.remote.artery.SendQueueSpec.test$1$$anonfun$adapted$1(SendQueueSpec.scala:175)
[11-25 02:13:26.569] [info]   at scala.collection.immutable.Range.foreach(Range.scala:190)
[11-25 02:13:26.569] [info]   at org.apache.pekko.remote.artery.SendQueueSpec.test$1(SendQueueSpec.scala:175)
[11-25 02:13:26.569] [info]   at org.apache.pekko.remote.artery.SendQueueSpec.f$proxy5$1(SendQueueSpec.scala:204)

[pjfanning]

lgtm - thanks

[raboof]

Great find, thank you!