chore: avoid create an empty array everytime. #1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
reviewed
Dec 22, 2024
stream/src/main/scala/org/apache/pekko/stream/impl/PhasedFusingActorMaterializer.scala
Outdated
Show resolved
Hide resolved
stream/src/main/scala/org/apache/pekko/stream/impl/PhasedFusingActorMaterializer.scala
Show resolved
Hide resolved
He-Pin
force-pushed
the
avoidEmptyArary
branch
from
85fee8f to
dcef05b
Compare
pjfanning
approved these changes
Dec 28, 2024
Member
pjfanning
left a comment
pjfanning
left a comment
There was a problem hiding this comment.
lgtm - main is now dev branch for 1.2.0
jxnu-liguobin
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Code clean up and performance.
Modification:
I found this todo when read the code, and we should avoid creating the empty array everytime.