chore: tidy up implementation of PhasedFusingActorMaterializer #1617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
changed the title
raboof
approved these changes
Dec 22, 2024
Member
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
Removing s and making return values explicit is nice.
I'm not sure about adding private: the advantage is that it reduces the scope of the variable, but it's already in a @InternalApi private[pekko] final class so I'm not sure it's worth the noise. I'm OK with it though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Code clean-up with IDEA
Modification:
remove
sand make fields private.