perf: Reduce loops when cleaning queue in BroadcastHub #1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
changed the title
He-Pin
requested review from
Roiocam,
jrudolph,
mdedetrich,
pjfanning and
raboof
Member
Author
|
it's better not to change the code in var upToOffset = head
while (consumerWheel(upToOffset & WheelMask).isEmpty) {
upToOffset += 1
unblocked = true
}
if (upToOffset != head) {
cleanQueueInRange(head, upToOffset)
head = upToOffset
} |
Member
|
Can we keep this till v1.2.0? We've had a couple of breaks due to optimisations like this. |
Member
Author
|
I'm not sure if this should be marked as a bug or not. |
He-Pin
commented
Dec 28, 2024
| while (head != finalOffset) { | ||
| queue(head & Mask) = null | ||
| head += 1 | ||
| } |
Member
Author
There was a problem hiding this comment.
Which can loop many times
Member
Author
|
@pjfanning I want to backport to 1.1.x too, wdyt |
He-Pin
added a commit
to He-Pin/incubator-pekko
that referenced
this pull request
Dec 30, 2024
(cherry picked from commit 9596ea4)
pjfanning
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
refs: #1627
Modification:
Reduce the loop count
Result:
Reduce the loop count
@andreaslochbihler-da cc as he is the origin reporter