Skip to content

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented Nov 17, 2025

fixes #2509

Not having a semver version and having sbt-dynver derive versions like HEAD+20251117-1039 when the code is not under git control leads to other problems with the build but this issue breaks the build.

Other issues that we get with HEAD+20251117-1039 style versions include:

[error] bnd: Invalid value for Bundle-Version, HEAD+20251117-1039 does not match \d{1,9}(\.\d{1,9}(\.\d{1,9}(\.[-\w]+)?)?)?

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

}
}
private def useDefaultImportRange(version: String, packageName: String) = {
System.err.println(s"Invalid Pekko version: $version for OSGi import package versioning, defaulting to [0.0,10.0)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to use err here

@pjfanning pjfanning merged commit e42ba37 into apache:main Nov 17, 2025
9 checks passed
@pjfanning pjfanning deleted the osgi-build-issue branch November 17, 2025 16:38
pjfanning added a commit to pjfanning/incubator-pekko that referenced this pull request Nov 17, 2025
* handle build issue in OSGi build code

* Update OSGi.scala
pjfanning added a commit to pjfanning/incubator-pekko that referenced this pull request Nov 17, 2025
* handle build issue in OSGi build code

* Update OSGi.scala
pjfanning added a commit that referenced this pull request Nov 17, 2025
* handle build issue in OSGi build code

* Update OSGi.scala
pjfanning added a commit that referenced this pull request Nov 17, 2025
* handle build issue in OSGi build code

* Update OSGi.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OSGI build throws an exception if version value in sbt is not in x.y.z format

3 participants