chore: optimize Source#future and Source#futureSource (#2560)#2583
Merged
chore: optimize Source#future and Source#futureSource (#2560)#2583
Conversation
* chore: optimize Source#future and Source#futureSource --------- Co-authored-by: PJ Fanning <pjfanning@users.noreply.github.com> (cherry picked from commit 01f2265) # Conflicts: # stream-tests/src/test/scala/org/apache/pekko/stream/impl/TraversalBuilderSpec.scala
Member
Author
|
@pjfanning This is ready for 1.5.x |
Member
|
Honestly, I'd prefer to concentrate on 2.0.0 at this stage. I don't see why we need to backport half of the changes to 1.x. |
Member
Author
|
This is a performance optimization. |
pjfanning
approved these changes
Dec 15, 2025
Member
pjfanning
left a comment
pjfanning
left a comment
There was a problem hiding this comment.
Lgtm. Such 1.x changes not a big priority for me but this one seems ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: PJ Fanning pjfanning@users.noreply.github.com
(cherry picked from commit 01f2265)