[ui] Added primary key icon for easy identification in schema view #17588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17588 +/- ##
============================================
- Coverage 63.19% 63.18% -0.02%
- Complexity 1476 1477 +1
============================================
Files 3172 3172
Lines 189806 189806
Branches 29046 29046
============================================
- Hits 119945 119922 -23
- Misses 60548 60560 +12
- Partials 9313 9324 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
What a coincidence, we just merged #17566 which is essentially doing the same but with a different UX design |
Collaborator
Author
|
@Jackie-Jiang indeed! I like the other one, I just thought there might be a reason why primary keys were not included earlier, and hence just wanted a small primary key indicator for visibility! Glad to see that merged, I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While the current schema view in the table page in Pinot Controller has a few columns for each column denoting its metadata, there is no easy visual way to see if a column is a primary key or not (we need to toggle JSON to view the primary keys). This PR adds a key icon after the columns which are a part of the primary keys for that table.
Testing
Successfully tested in Quickstart.
