Use alarming sleep time for CRITICAL and PANIC level#17788
Use alarming sleep time for CRITICAL and PANIC level#17788Jackie-Jiang wants to merge 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the query accounting trigger evaluation so that when heap usage reaches CRITICAL or PANIC levels, the system also switches to the more frequent alarming sleep time, enabling faster follow-up checks during severe memory pressure.
Changes:
- Apply
alarmingSleepTimewhen heap usage exceeds the alarming threshold, including when it is also CRITICAL/PANIC. - Restructure trigger evaluation logic in both the global (
QueryResourceAggregator) and per-query (PerQueryCPUMemAccountantFactory) accounting paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pinot-core/src/main/java/org/apache/pinot/core/accounting/QueryResourceAggregator.java | Restructures heap trigger evaluation so CRITICAL/PANIC also use alarming sleep time. |
| pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java | Mirrors the same trigger/sleep-time restructuring for the per-query accountant. |
pinot-core/src/main/java/org/apache/pinot/core/accounting/QueryResourceAggregator.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/accounting/QueryResourceAggregator.java
Outdated
Show resolved
Hide resolved
9db0cbf to
1884a29
Compare
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/accounting/QueryResourceAggregator.java
Show resolved
Hide resolved
e544d82 to
38acca5
Compare
pinot-core/src/main/java/org/apache/pinot/core/accounting/QueryResourceAggregator.java
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/accounting/QueryResourceAggregator.java
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17788 +/- ##
============================================
- Coverage 63.23% 63.22% -0.01%
Complexity 1454 1454
============================================
Files 3183 3183
Lines 191430 191512 +82
Branches 29274 29291 +17
============================================
+ Hits 121047 121083 +36
- Misses 60943 60964 +21
- Partials 9440 9465 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
38acca5 to
e32c9e2
Compare
Check more frequently for CRITICAL and PANIC level