Skip to content

feat: add CATALOG_READ_DATA privilege for data analyst read-only catalog access #3927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Praneeth-Sagar-13 wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −2
Open

feat: add CATALOG_READ_DATA privilege for data analyst read-only catalog access #3927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ public class PolarisAuthorizerImpl implements PolarisAuthorizer {
List.of(
CATALOG_MANAGE_CONTENT,
CATALOG_MANAGE_METADATA,
CATALOG_READ_DATA,
NAMESPACE_CREATE,
NAMESPACE_FULL_METADATA,
NAMESPACE_LIST,
Expand All @@ -210,6 +211,7 @@ public class PolarisAuthorizerImpl implements PolarisAuthorizer {
List.of(
CATALOG_MANAGE_CONTENT,
CATALOG_MANAGE_METADATA,
CATALOG_READ_DATA,
TABLE_CREATE,
TABLE_FULL_METADATA,
TABLE_LIST,
Expand All @@ -222,6 +224,7 @@ public class PolarisAuthorizerImpl implements PolarisAuthorizer {
List.of(
CATALOG_MANAGE_CONTENT,
CATALOG_MANAGE_METADATA,
CATALOG_READ_DATA,
VIEW_CREATE,
VIEW_FULL_METADATA,
VIEW_LIST,
Expand All @@ -232,6 +235,7 @@ public class PolarisAuthorizerImpl implements PolarisAuthorizer {
List.of(
CATALOG_MANAGE_CONTENT,
CATALOG_MANAGE_METADATA,
CATALOG_READ_DATA,
NAMESPACE_FULL_METADATA,
NAMESPACE_READ_PROPERTIES,
NAMESPACE_WRITE_PROPERTIES));
Expand All @@ -240,6 +244,7 @@ public class PolarisAuthorizerImpl implements PolarisAuthorizer {
List.of(
CATALOG_MANAGE_CONTENT,
CATALOG_MANAGE_METADATA,
CATALOG_READ_DATA,
TABLE_FULL_METADATA,
TABLE_READ_DATA,
TABLE_READ_PROPERTIES,
Expand All @@ -250,6 +255,7 @@ public class PolarisAuthorizerImpl implements PolarisAuthorizer {
List.of(
CATALOG_MANAGE_CONTENT,
CATALOG_MANAGE_METADATA,
CATALOG_READ_DATA,
VIEW_FULL_METADATA,
VIEW_READ_PROPERTIES,
VIEW_WRITE_PROPERTIES));
Expand Down Expand Up @@ -453,8 +459,11 @@ public class PolarisAuthorizerImpl implements PolarisAuthorizer {
VIEW_FULL_METADATA,
VIEW_WRITE_PROPERTIES));
SUPER_PRIVILEGES.putAll(
TABLE_READ_DATA, List.of(CATALOG_MANAGE_CONTENT, TABLE_READ_DATA, TABLE_WRITE_DATA));
TABLE_READ_DATA,
List.of(CATALOG_MANAGE_CONTENT, CATALOG_READ_DATA, TABLE_READ_DATA, TABLE_WRITE_DATA));
SUPER_PRIVILEGES.putAll(TABLE_WRITE_DATA, List.of(CATALOG_MANAGE_CONTENT, TABLE_WRITE_DATA));
SUPER_PRIVILEGES.putAll(
CATALOG_READ_DATA, List.of(CATALOG_MANAGE_CONTENT, CATALOG_READ_DATA));
SUPER_PRIVILEGES.putAll(
NAMESPACE_FULL_METADATA,
List.of(CATALOG_MANAGE_CONTENT, CATALOG_MANAGE_METADATA, NAMESPACE_FULL_METADATA));
Expand Down
10 changes: 10 additions & 0 deletions polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrivilege.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,16 @@ public enum PolarisPrivilege {
PolarisEntityType.TABLE_LIKE,
List.of(PolarisEntitySubType.ICEBERG_TABLE, PolarisEntitySubType.GENERIC_TABLE),
PolarisEntityType.CATALOG_ROLE),
/**
* Grants read-only access to all data and navigational metadata within a specific catalog.
* Intended for data analyst principals who need to read tables and views across an entire catalog
* without any write or administrative capabilities.
*
* <p>This privilege subsumes: {@link #NAMESPACE_LIST}, {@link #NAMESPACE_READ_PROPERTIES},
* {@link #TABLE_LIST}, {@link #TABLE_READ_PROPERTIES}, {@link #TABLE_READ_DATA}, {@link
* #VIEW_LIST}, and {@link #VIEW_READ_PROPERTIES}.
*/
CATALOG_READ_DATA(103, PolarisEntityType.CATALOG),
;

/**
Expand Down
3 changes: 2 additions & 1 deletion polaris-core/src/test/java/org/apache/polaris/core/entity/PolarisPrivilegeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ static Stream<Arguments> polarisPrivileges() {
Arguments.of(100, PolarisPrivilege.TABLE_REMOVE_STATISTICS),
Arguments.of(101, PolarisPrivilege.TABLE_REMOVE_PARTITION_SPECS),
Arguments.of(102, PolarisPrivilege.TABLE_MANAGE_STRUCTURE),
Arguments.of(103, null));
Arguments.of(103, PolarisPrivilege.CATALOG_READ_DATA),
Arguments.of(104, null));
}

@ParameterizedTest
Expand Down
1 change: 1 addition & 0 deletions spec/polaris-management-service.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1582,6 +1582,7 @@ components:
- CATALOG_MANAGE_ACCESS
- CATALOG_MANAGE_CONTENT
- CATALOG_MANAGE_METADATA
- CATALOG_READ_DATA
- CATALOG_READ_PROPERTIES
- CATALOG_WRITE_PROPERTIES
- NAMESPACE_CREATE
Expand Down