[Issue #45] [pulsar-client-kafka-compat] Handled Kafka record headers… #46
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package org.apache.kafka.clients.constants; | ||
|
|
||
| public final class MessageConstants { | ||
| private MessageConstants() { | ||
|
|
||
| } | ||
|
|
||
| public static final String KAFKA_MESSAGE_HEADER_PREFIX = "kafka.header."; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.kafka.clients.consumer; | ||
|
|
||
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.ArgumentMatchers.anyCollection; | ||
| import static org.mockito.ArgumentMatchers.anyString; | ||
| import static org.mockito.Mockito.doNothing; | ||
| import static org.mockito.Mockito.doReturn; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.spy; | ||
| import static org.mockito.Mockito.when; | ||
| import java.util.Collections; | ||
| import java.util.Properties; | ||
| import org.apache.kafka.common.serialization.IntegerDeserializer; | ||
| import org.apache.kafka.common.serialization.StringDeserializer; | ||
| import org.apache.pulsar.client.api.ClientBuilder; | ||
| import org.apache.pulsar.client.api.Consumer; | ||
| import org.apache.pulsar.client.api.Message; | ||
| import org.apache.pulsar.client.api.MessageId; | ||
| import org.apache.pulsar.client.api.PulsarClient; | ||
| import org.apache.pulsar.client.util.MessageIdUtils; | ||
| import org.apache.pulsar.common.naming.TopicName; | ||
| import org.powermock.api.mockito.PowerMockito; | ||
| import org.powermock.core.classloader.annotations.PowerMockIgnore; | ||
| import org.powermock.core.classloader.annotations.PrepareForTest; | ||
| import org.testng.IObjectFactory; | ||
| import org.testng.annotations.ObjectFactory; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| @PrepareForTest({TopicName.class, MessageIdUtils.class}) | ||
| @PowerMockIgnore({"org.apache.logging.log4j.*"}) | ||
| public class PulsarKafkaConsumerTest { | ||
|
|
||
| @ObjectFactory | ||
| public IObjectFactory getObjectFactory() { | ||
| return new org.powermock.modules.testng.PowerMockObjectFactory(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testPulsarKafkaConsumerWithHeaders() throws Exception { | ||
| PowerMockito.mockStatic(TopicName.class); | ||
| PowerMockito.mockStatic(MessageIdUtils.class); | ||
swamymavuri marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| TopicName topicName = mock(TopicName.class); | ||
|
|
||
| doReturn("topic").when(topicName).getPartitionedTopicName(); | ||
|
|
||
| ClientBuilder mockClientBuilder = mock(ClientBuilder.class); | ||
| Consumer consumer = mock(Consumer.class); | ||
| Message msg = mock(Message.class); | ||
| MessageId msgId = mock(MessageId.class); | ||
|
|
||
| PulsarClient mockClient = mock(PulsarClient.class); | ||
|
|
||
| doReturn(mockClientBuilder).when(mockClientBuilder).serviceUrl(anyString()); | ||
| when(TopicName.get(any())).thenReturn(topicName); | ||
| when(msg.getMessageId()).thenReturn(msgId); | ||
| doReturn(mockClient).when(mockClientBuilder).build(); | ||
|
|
||
| Properties properties = new Properties(); | ||
|
|
||
| properties.put(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG, IntegerDeserializer.class.getName()); | ||
| properties.put(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG, StringDeserializer.class.getName()); | ||
| properties.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, Collections.singletonList("pulsar://localhost:6650")); | ||
| properties.put(ConsumerConfig.GROUP_ID_CONFIG, "my-subscription-name"); | ||
|
|
||
|
|
||
| PulsarKafkaConsumer<Integer, String> pulsarKafkaConsumerSpy = | ||
| spy(new PulsarKafkaConsumer<>(properties, new IntegerDeserializer(), new StringDeserializer())); | ||
|
|
||
| doNothing().when(pulsarKafkaConsumerSpy).seekToEnd(anyCollection()); | ||
| PowerMockito.whenNew(PulsarKafkaConsumer.class).withAnyArguments().thenReturn(pulsarKafkaConsumerSpy); | ||
|
|
||
| PulsarKafkaConsumer<Integer, String> pulsarKafkaConsumer = | ||
| new PulsarKafkaConsumer<>(properties, new IntegerDeserializer(), new StringDeserializer()); | ||
|
|
||
| pulsarKafkaConsumer.received(consumer, msg); | ||
| pulsarKafkaConsumer.poll(100); | ||
| pulsarKafkaConsumer.close(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testPulsarKafkaConsumer() throws Exception { | ||
|
||
| PowerMockito.mockStatic(TopicName.class); | ||
| PowerMockito.mockStatic(MessageIdUtils.class); | ||
|
|
||
| TopicName topicName = mock(TopicName.class); | ||
|
|
||
| doReturn("topic").when(topicName).getPartitionedTopicName(); | ||
|
|
||
| ClientBuilder mockClientBuilder = mock(ClientBuilder.class); | ||
| Consumer<byte[]> consumer = mock(Consumer.class); | ||
| Message<byte[]> msg = mock(Message.class); | ||
| MessageId msgId = mock(MessageId.class); | ||
|
|
||
| PulsarClient mockClient = mock(PulsarClient.class); | ||
|
|
||
| doReturn(mockClientBuilder).when(mockClientBuilder).serviceUrl(anyString()); | ||
| when(TopicName.get(any())).thenReturn(topicName); | ||
| when(msg.getMessageId()).thenReturn(msgId); | ||
| doReturn(mockClient).when(mockClientBuilder).build(); | ||
|
|
||
| Properties properties = new Properties(); | ||
|
|
||
| properties.put(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG, IntegerDeserializer.class.getName()); | ||
| properties.put(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG, StringDeserializer.class.getName()); | ||
| properties.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, Collections.singletonList("pulsar://localhost:6650")); | ||
| properties.put(ConsumerConfig.GROUP_ID_CONFIG, "my-subscription-name"); | ||
|
|
||
|
|
||
| PulsarKafkaConsumer<Integer, String> pulsarKafkaConsumerSpy = | ||
| spy(new PulsarKafkaConsumer<>(properties, new IntegerDeserializer(), new StringDeserializer())); | ||
|
|
||
| doNothing().when(pulsarKafkaConsumerSpy).seekToEnd(anyCollection()); | ||
| PowerMockito.whenNew(PulsarKafkaConsumer.class).withAnyArguments().thenReturn(pulsarKafkaConsumerSpy); | ||
|
|
||
| PulsarKafkaConsumer<Integer, String> pulsarKafkaConsumer = | ||
| new PulsarKafkaConsumer<>(properties, new IntegerDeserializer(), new StringDeserializer()); | ||
|
|
||
| pulsarKafkaConsumer.poll(100); | ||
| pulsarKafkaConsumer.close(); | ||
| } | ||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this import used at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, while encoding the kafka record headers