Upgrade test image to use clang-tidy 17

Author: BewareMyPower

.github/workflows/ci-pr-validation.yaml

@@ -80,7 +80,7 @@ jobs:
   lint:
     name: Lint
     needs: formatting-check
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 120
 
     steps:
@@ -107,7 +107,7 @@ jobs:
   unit-tests:
     name: Run unit tests
     needs: formatting-check
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     timeout-minutes: 120
 
     steps:

build-support/run_clang_tidy.sh

@@ -29,4 +29,6 @@ rm -f files.txt
 for FILE in $FILES; do
     echo $FILE >> files.txt
 done
-run-clang-tidy -p build $(cat files.txt)
+# On macOS, run-clang-tidy from llvm@17 requires python as the env, so we cannot run it directly
+SCRIPT=$(which run-clang-tidy)
+python3 $SCRIPT -p build $(cat files.txt)

lib/Commands.cc

@@ -138,7 +138,7 @@ SharedBuffer Commands::newPartitionMetadataRequest(const std::string& topic, uin
     CommandPartitionedTopicMetadata* partitionMetadata = cmd.mutable_partitionmetadata();
     partitionMetadata->set_topic(topic);
     partitionMetadata->set_request_id(requestId);
-    const SharedBuffer buffer = writeMessageWithSize(cmd);
+    SharedBuffer buffer = writeMessageWithSize(cmd);
     cmd.clear_partitionmetadata();
     return buffer;
 }
@@ -154,7 +154,7 @@ SharedBuffer Commands::newLookup(const std::string& topic, const bool authoritat
     lookup->set_authoritative(authoritative);
     lookup->set_request_id(requestId);
     lookup->set_advertised_listener_name(listenerName);
-    const SharedBuffer buffer = writeMessageWithSize(cmd);
+    SharedBuffer buffer = writeMessageWithSize(cmd);
     cmd.clear_lookuptopic();
     return buffer;
 }
@@ -173,7 +173,7 @@ SharedBuffer Commands::newGetSchema(const std::string& topic, const std::string&
         getSchema->set_schema_version(version);
     }
 
-    const SharedBuffer buffer = writeMessageWithSize(cmd);
+    SharedBuffer buffer = writeMessageWithSize(cmd);
     cmd.clear_getschema();
     return buffer;
 }
@@ -186,7 +186,7 @@ SharedBuffer Commands::newConsumerStats(uint64_t consumerId, uint64_t requestId)
     CommandConsumerStats* consumerStats = cmd.mutable_consumerstats();
     consumerStats->set_consumer_id(consumerId);
     consumerStats->set_request_id(requestId);
-    const SharedBuffer buffer = writeMessageWithSize(cmd);
+    SharedBuffer buffer = writeMessageWithSize(cmd);
     cmd.clear_consumerstats();
     return buffer;
 }
@@ -618,7 +618,7 @@ SharedBuffer Commands::newGetLastMessageId(uint64_t consumerId, uint64_t request
     CommandGetLastMessageId* getLastMessageId = cmd.mutable_getlastmessageid();
     getLastMessageId->set_consumer_id(consumerId);
     getLastMessageId->set_request_id(requestId);
-    const SharedBuffer buffer = writeMessageWithSize(cmd);
+    SharedBuffer buffer = writeMessageWithSize(cmd);
     cmd.clear_getlastmessageid();
     return buffer;
 }
@@ -632,7 +632,7 @@ SharedBuffer Commands::newGetTopicsOfNamespace(const std::string& nsName,
     getTopics->set_namespace_(nsName);
     getTopics->set_mode(static_cast<proto::CommandGetTopicsOfNamespace_Mode>(mode));
 
-    const SharedBuffer buffer = writeMessageWithSize(cmd);
+    SharedBuffer buffer = writeMessageWithSize(cmd);
     cmd.clear_gettopicsofnamespace();
     return buffer;
 }

lib/auth/AuthOauth2.cc

@@ -124,7 +124,7 @@ KeyFile KeyFile::fromParamMap(ParamMap& params) {
         if (endPos == std::string::npos) {
             return "";
         }
-        const auto prefix = url.substr(startPos, endPos - startPos);
+        auto prefix = url.substr(startPos, endPos - startPos);
         startPos = endPos + 1;
         return prefix;
     };