Skip to content

Conversation

@miton18
Copy link
Contributor

@miton18 miton18 commented Aug 28, 2025

Motivation

Some features on the API are not exposes through the admin client

Modifications

add missing methods

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:
TestNamespaces_GetMaxTopicsPerNamespace

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? not applicable
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@miton18 miton18 force-pushed the feat/max-topics-per-namespace branch from 5939acc to 55c0e66 Compare August 28, 2025 15:19
@lhotari
Copy link
Member

lhotari commented Aug 28, 2025

@miton18 Thanks for the contribution! Please merge origin/master to your PR branch to resolve the conflicts or rebase your PR.

@miton18 miton18 force-pushed the feat/max-topics-per-namespace branch from 55c0e66 to afa35c5 Compare September 1, 2025 04:52
@miton18 miton18 force-pushed the feat/max-topics-per-namespace branch from afa35c5 to 9dd4666 Compare September 1, 2025 04:53
@lhotari lhotari requested a review from Copilot September 1, 2025 15:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds missing methods to the Pulsar admin client for managing the maximum number of topics per namespace. The implementation provides complete CRUD operations for this namespace-level configuration.

  • Added three new methods to the Namespaces interface: SetMaxTopicsPerNamespace, GetMaxTopicsPerNamespace, and RemoveMaxTopicsPerNamespace
  • Implemented the corresponding methods in the namespaces struct with proper REST API endpoints
  • Added comprehensive test coverage for all new functionality including edge cases

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pulsaradmin/pkg/admin/namespace.go Adds interface definitions and implementations for max topics per namespace operations
pulsaradmin/pkg/admin/namespace_test.go Adds test cases covering valid/invalid scenarios and CRUD operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@crossoverJie crossoverJie added this to the v0.17.0 milestone Sep 2, 2025
@crossoverJie
Copy link
Member

Thank you for your contribution, merging.

@crossoverJie crossoverJie merged commit 230d11b into apache:master Sep 2, 2025
11 of 12 checks passed
@miton18 miton18 deleted the feat/max-topics-per-namespace branch September 2, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants