Feat/max topics per namespace#1413
Merged
crossoverJie merged 1 commit intoapache:masterfrom Sep 2, 2025
Merged
Conversation
5939acc to
55c0e66
Compare
Member
|
@miton18 Thanks for the contribution! Please merge origin/master to your PR branch to resolve the conflicts or rebase your PR. |
55c0e66 to
afa35c5
Compare
afa35c5 to
9dd4666
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing methods to the Pulsar admin client for managing the maximum number of topics per namespace. The implementation provides complete CRUD operations for this namespace-level configuration.
- Added three new methods to the Namespaces interface:
SetMaxTopicsPerNamespace,GetMaxTopicsPerNamespace, andRemoveMaxTopicsPerNamespace - Implemented the corresponding methods in the namespaces struct with proper REST API endpoints
- Added comprehensive test coverage for all new functionality including edge cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pulsaradmin/pkg/admin/namespace.go | Adds interface definitions and implementations for max topics per namespace operations |
| pulsaradmin/pkg/admin/namespace_test.go | Adds test cases covering valid/invalid scenarios and CRUD operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
crossoverJie
approved these changes
Sep 2, 2025
Member
|
Thank you for your contribution, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some features on the API are not exposes through the admin client
Modifications
add missing methods
Verifying this change
This change added tests and can be verified as follows:
TestNamespaces_GetMaxTopicsPerNamespace
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation