[Improve] Add PR-template #1196
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertIndie
reviewed
Mar 9, 2024
.github/PULL_REQUEST_TEMPLATE.md
Outdated
Comment on lines
78
to
79
| After opening this PR, the build in apache/pulsar-client-go will fail and instructions will | ||
| be provided for opening a PR in the PR author's forked repository. |
Member
There was a problem hiding this comment.
We didn't add this restriction to the pulsar-client-go repo. For non-committer contributors, it's required by the ASF that their PRs' CI must be approved by a committer before running the CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add a
PR in forkedsection, conveniently check the running results of CI.