Skip to content

[Issue #1418] Fix: Properties not getting consistently set on pulsaradmin subscription message responses #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobertIndie merged 5 commits into from
Sep 8, 2025
Merged

[Issue #1418] Fix: Properties not getting consistently set on pulsaradmin subscription message responses #1419

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
871fa18
Fix: Properties not getting consistently set on pulsaradmin subscript…
JamesMurkin Sep 3, 2025
6cac146
tidy
JamesMurkin Sep 3, 2025
78758de
Add to unit test
JamesMurkin Sep 4, 2025
fd1a5e4
Improve TestPeekMessagesWithProperties
JamesMurkin Sep 4, 2025
5951a81
Lint
JamesMurkin Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pulsaradmin/pkg/admin/subscription.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ func handleResp(topic utils.TopicName, resp *http.Response) ([]*utils.Message, e
}

properties := make(map[string]string)
isBatch := false
for k := range resp.Header {
switch {
case k == PublishTimeHeader:
Expand All @@ -268,7 +269,7 @@ func handleResp(topic utils.TopicName, resp *http.Response) ([]*utils.Message, e
if h != "" {
properties[BatchHeader] = h
}
return getIndividualMsgsFromBatch(topic, ID, payload, properties)
isBatch = true
case k == PropertyHeader:
propJSON := resp.Header.Get(k)
if err := json.Unmarshal([]byte(propJSON), &properties); err != nil {
Expand All @@ -280,6 +281,9 @@ func handleResp(topic utils.TopicName, resp *http.Response) ([]*utils.Message, e
}
}

if isBatch {
return getIndividualMsgsFromBatch(topic, ID, payload, properties)
}
return []*utils.Message{utils.NewMessage(topic.String(), *ID, payload, properties)}, nil
}

Expand Down