fix: improve zero queue consumer support for partitioned topics#1424
fix: improve zero queue consumer support for partitioned topics#1424crossoverJie merged 4 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes zero queue consumer support for partitioned topics by allowing consumers to target specific partitions rather than rejecting all partitioned topics.
- Removes the restriction that prevented zero queue consumers from working with partitioned topics
- Updates partition index validation to use the actual partition index instead of hardcoded zero
- Adds proper error handling for Ack operations in tests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pulsar/consumer_impl.go | Removes partitioned topic detection logic that blocked zero queue consumers |
| pulsar/consumer_zero_queue.go | Updates partition index handling to parse topic name and use actual partition index |
| pulsar/consumer_zero_queue_test.go | Adds test coverage for specified partition consumers and improves error handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Maybe related #1443 |
Fixes #1421
Motivation
zero queue consumer support for partitioned topics.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation