Optimize negative_acks_tracker by time_wheel #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Curious how does this improve or enhance the current implementation? Why would users want to use this over what is currently there? What is the added overhead? |
Member
|
Thanks @EAHITechnology work for this. I am a little confused here, why do we need to use the time wheel to handle nack tasks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that the task trigger time is relatively late, it is possible that the time complexity of traversing a map is O(n), but nothing is actually done, which leads to a waste of CPU time. The time wheel data structure can effectively reduce the order of magnitude of scanning. At the same time, this part of the logic can also be hidden behind the business logic in the internal.go