fix 640,change create way is same as java client #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfstudy
requested changes
Oct 15, 2021
wolfstudy
reviewed
Oct 15, 2021
pulsar/consumer_partition.go
Outdated
| if err != nil { | ||
| pc.log.WithError(err).Warn("Failed to lookup topic") | ||
| pc.log.WithError(err).Warn("Failed to lookup topic, it will be retried later!") | ||
| pc.connectClosedCh <- connectionClosed{} |
Member
There was a problem hiding this comment.
When the Lookup request fails, it is inconsistent with the connectionClosed error. At this time, we don’t need to write back the semaphore to the closed channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #640
Master Issue: #640
go client create producer and consumer client way is different with java client. and go client will throw error when call grabCnx while Lookup or after sending CommandProducer.
if use get this error, use must retry recreate client and this way is not neccessary. and connect need to reconnect while send or connect check way.
java client handle like this, so it need be changed .
and java code is this