Skip to content

Conversation

@TakaHiR07
Copy link
Contributor

@TakaHiR07 TakaHiR07 commented Mar 16, 2023

Motivation

If we enable batch message, sometimes we need to get the exact message in a batch or get the whole batch messages to help find out some problems. But now the admin getMessageById() method can only get the first message in a batch.

Modifications

  1. implement getBatchMessagesById() to get the whole batch messages in a entry
  2. implement get the exact batch message in the getMessageById() methods, and ensure the compatibility with previous behaviour
  3. add unittest for these implementation

Verifying this change

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: TakaHiR07#3

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Mar 16, 2023
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Apr 16, 2023
@Technoboy- Technoboy- added this to the 3.2.0 milestone Jul 31, 2023
@Technoboy- Technoboy- modified the milestones: 3.2.0, 3.3.0 Dec 22, 2023
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 14, 2024
@coderzc coderzc modified the milestones: 4.1.0, 4.2.0 Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required Your PR changes impact docs and you will update later. Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants