Skip to content

[fix][broker] Correct the 'connected' status in topic stats of multi-partition topic for geo replication #23523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Coselding wants to merge 4 commits into from
Closed

[fix][broker] Correct the 'connected' status in topic stats of multi-partition topic for geo replication #23523

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aab604a
[improve][admin]add comment for topic level admin interface parameter…
May 27, 2024
cfa9117
Merge remote-tracking branch 'origin/master'
Oct 28, 2024
83a3375
[fix][broker]correct the 'ReplicatorStatsImpl.connected' default value
Oct 28, 2024
5c95ee5
Revert "[improve][admin]add comment for topic level admin interface p…
Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4354,6 +4354,7 @@ CompletableFuture<Message<byte[]>> examineMessageAsync(String topic, String init
*
* @param topic
* @param applied
* Whether to return the configuration value of the previous level if the current level's don't set
Copy link
Member

@lhotari lhotari Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this update related to this pull request? If not, please remove from this PR and improve the javadoc in a separate PR.

* @return
* @throws PulsarAdminException
*/
Expand All @@ -4364,6 +4365,7 @@ CompletableFuture<Message<byte[]>> examineMessageAsync(String topic, String init
*
* @param topic
* @param applied
* Whether to return the configuration value of the previous level if the current level's don't set
Copy link
Member

@lhotari lhotari Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this update related to this pull request? If not, please remove from this PR and improve the javadoc in a separate PR.

Copy link
Author

@Coselding Coselding Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I corrected the problem and submitted a new Pull Request. #23695

* @return
* @throws PulsarAdminException
*/
Expand Down
2 changes: 1 addition & 1 deletion ...ommon/src/main/java/org/apache/pulsar/common/policies/data/stats/ReplicatorStatsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public class ReplicatorStatsImpl implements ReplicatorStats {
public long replicationBacklog;

/** is the replication-subscriber up and running to replicate to remote cluster. */
public boolean connected;
public boolean connected = true;

/** Time in seconds from the time a message was produced to the time when it is about to be replicated. */
public long replicationDelayInSeconds;
Expand Down