[fix][client] Fix memory leak when message size exceeds max message size and batching is enabled #23967
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize and batching is enabled
lhotari
requested review from
RobertIndie,
Technoboy-,
dao-jun,
merlimat,
nodece,
poorbarcode and
shibd
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23967 +/- ##
============================================
+ Coverage 73.57% 74.23% +0.65%
+ Complexity 32624 32260 -364
============================================
Files 1877 1853 -24
Lines 139502 143822 +4320
Branches 15299 16337 +1038
============================================
+ Hits 102638 106762 +4124
+ Misses 28908 28669 -239
- Partials 7956 8391 +435
Flags with carried forward coverage won't be shown. Click here to find out more.
|
merlimat
approved these changes
Feb 12, 2025
merlimat
pushed a commit
that referenced
this pull request
Feb 12, 2025
…ize and batching is enabled (#23967)
merlimat
pushed a commit
that referenced
this pull request
Feb 12, 2025
…ize and batching is enabled (#23967)
merlimat
pushed a commit
that referenced
this pull request
Feb 12, 2025
…ize and batching is enabled (#23967)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 19, 2025
…ize and batching is enabled (apache#23967) (cherry picked from commit 2620871)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 20, 2025
…ize and batching is enabled (apache#23967) (cherry picked from commit 866a82b)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 24, 2025
…ize and batching is enabled (apache#23967) (cherry picked from commit 2620871)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When enabling Netty leak detection with #23956 changes at
paranoidlevel, BatchMessageTest.testSendOverSizeMessage shows a Netty ByteBuf memory leak. This is a bug in BatchMessageContainerImpl. It doesn't release the payload when the message size exceeds max message size.Modifications
Additional context
After #23956 changes are included, it is possible to catch such memory leaks in pull request CI builds.
Documentation
docdoc-requireddoc-not-neededdoc-complete