-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][broker] Upgrade bookkeeper to 4.17.2/commons-configuration to 2.x/grpc to 1.72.0 and enable ZooKeeper client to establish connection in read-only mode #24468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
605094a to
15b1d95
Compare
110a3e9 to
a78328e
Compare
9f63ce6 to
9592a84
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24468 +/- ##
============================================
+ Coverage 73.57% 74.25% +0.67%
+ Complexity 32624 32411 -213
============================================
Files 1877 1868 -9
Lines 139502 145762 +6260
Branches 15299 16701 +1402
============================================
+ Hits 102638 108232 +5594
- Misses 28908 28943 +35
- Partials 7956 8587 +631
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Good work! However, I think we can split the common-lang -> commons-lang3 migration to a separate PR. In that separate PR it would also be useful to add check style rules that prevent using commons-lang for new code. |
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/PulsarZooKeeperClient.java
Show resolved
Hide resolved
@lhotari Good suggestion, I will split this out and submit a separate PR |
I have proposed a new one. After #24473 is merged, I will delete the duplicate code, rebase the master and push it again. |
9592a84 to
dee7dee
Compare
dee7dee to
5902d5f
Compare
…ons-configuration 2.x, base on apache/bookkeeper#4604
5902d5f to
2d025b0
Compare
|
/pulsarbot run-failure-checks |
eolivelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please make it clear in the title that we are also updating other libraries
It would be better to split the patch, but I understand it is not possible
|
Will this be backported to |
|
Finished: two labels have been added, release/3.3.8 and release/4.0.6 |
|
After bookeeper is upgraded, all |
…to 2.x/grpc to 1.72.0 and enable ZooKeeper client to establish connection in read-only mode (apache#24468)
…to 2.x/grpc to 1.72.0 and enable ZooKeeper client to establish connection in read-only mode (apache#24468) (cherry picked from commit 8d1ec6d) (cherry picked from commit 22ff023)
…to 2.x/grpc to 1.72.0 and enable ZooKeeper client to establish connection in read-only mode (apache#24468) (cherry picked from commit 8d1ec6d) (cherry picked from commit 22ff023)
…to 2.x/grpc to 1.72.0 and enable ZooKeeper client to establish connection in read-only mode (apache#24468)
…to 2.x/grpc to 1.72.0 and enable ZooKeeper client to establish connection in read-only mode (apache#24468)
Background
Upgrade bookkeeper to 4.17.2
Modifications
[improve][broker] Upgrade bookkeeper to 4.17.2
[improve][build] Migrate deprecated commons-configuration 1.x to commons-configuration 2.x, base on Migrate deprecated commons-configuration 1.x to commons-configuration 2.x bookkeeper#4604
2.1. import change: org.apache.commons.configuration to org.apache.commons.configuration2
2.2. impl change: setDelimiterParsingDisabled(true) to setListDelimiterHandler(new DisabledListDelimiterHandler())
Enable ZooKeeper client to establish connection in read-only mode, base on Enable ZooKeeper client to establish connection in read-only mode bookkeeper#4244
Upgrade gRPC to 1.72.0 : grpc version match to bookeeper 4.17.2, base on Upgrade to grpc 1.72.0 bookkeeper#4591
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
Check the box below or label this PR directly.
Need to update docs?
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: StevenLuMT#15