[fix][broker] Rename TopicBacklogQuotaExceededException to TopicBlock…#25205
Open
DoChaoing wants to merge 1 commit intoapache:masterfrom
Open
[fix][broker] Rename TopicBacklogQuotaExceededException to TopicBlock…#25205DoChaoing wants to merge 1 commit intoapache:masterfrom
DoChaoing wants to merge 1 commit intoapache:masterfrom
Conversation
…edQuotaExceededException Fixes apache#25168
|
@DoChaoing Please add the following content to your PR description and select a checkbox: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[fix][broker] Rename TopicBacklogQuotaExceededException to TopicBlockedQuotaExceededException
Fixes #25168
Motivation
Based on the code, there is a naming inconsistency between server-side and client-side exceptions:
ProducerBacklogQuotaExceededError, the exception class isTopicBacklogQuotaExceededExceptionProducerBlockedQuotaExceededExceptionorProducerBlockedQuotaExceededErrorThis makes it difficult for developers to locate key information from the server-side code when debugging quota-related issues.
Modifications
Renamed
TopicBacklogQuotaExceededExceptionto TopicBlockedQuotaExceededException in the following files:Verifying this change
This change is already covered by existing tests, such as:
BacklogQuotaManagerTest- Tests backlog quota enforcementPersistentTopicTest- Tests topic behavior with quota exceededDoes this pull request potentially affect one of the following parts:
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: https://github.com/DoChaoing/pulsar/pull/1