[feat] PIP-454: Metadata Store Migration Framework (implementation)#25219
Open
merlimat wants to merge 7 commits intoapache:masterfrom
Open
[feat] PIP-454: Metadata Store Migration Framework (implementation)#25219merlimat wants to merge 7 commits intoapache:masterfrom
merlimat wants to merge 7 commits intoapache:masterfrom
Conversation
github-actions
bot
added
the
doc-required
lhotari
reviewed
Feb 6, 2026
Comment on lines
+69
to
+110
| /** | ||
| * Start the migration process. | ||
| * | ||
| * @throws Exception if migration fails | ||
| */ | ||
| public void startMigration() throws Exception { | ||
| log.info("=== Starting Migration ==="); | ||
| log.info("Source: {} (current)", sourceStore.getClass().getSimpleName()); | ||
| log.info("Target: {}", targetUrl); | ||
|
|
||
| try { | ||
| // 1. Create migration flag | ||
| setInitialMigrationPhase(); | ||
|
|
||
| // 2. Wait for participants to prepare | ||
| waitForPreparation(); | ||
|
|
||
| // 3. Copy persistent data | ||
| updatePhase(MigrationPhase.COPYING); | ||
| copyPersistentData(); | ||
|
|
||
| // 4. Set state to completed | ||
| updatePhase(MigrationPhase.COMPLETED); | ||
|
|
||
| log.info("=== Migration Complete ==="); | ||
| } catch (Exception e) { | ||
| log.error("Migration failed", e); | ||
| updatePhase(MigrationPhase.FAILED); | ||
| throw e; | ||
| } | ||
| } | ||
|
|
||
| private void setInitialMigrationPhase() throws MetadataStoreException { | ||
| try { | ||
| sourceStore.put(MigrationState.MIGRATION_FLAG_PATH, | ||
| ObjectMapperFactory.getMapper().writer() | ||
| .writeValueAsBytes(new MigrationState(MigrationPhase.PREPARATION, targetUrl)), | ||
| Optional.of(-1L)).get(); | ||
| } catch (Exception e) { | ||
| throw new MetadataStoreException(e); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Is there a solution that prevents starting a new migration unless there's no previous migration? I guess retrying would be allowed so the previous state could be failed. Is there a way to do a CAS update to ensure that only a single node becomes the coordinator?
lhotari
reviewed
Feb 6, 2026
| private void readCurrentState() throws MetadataStoreException { | ||
| try { | ||
| // Read the current state | ||
| var initialState = migrationStateCache.get(MigrationState.MIGRATION_FLAG_PATH).get(); |
Member
There was a problem hiding this comment.
since this is read only at startup time, I guess it could by pass the cache.
In addition, it might be necessary to read after using sync on Zookeeper to ensure that it's the most recent state.
I guess it would be a small chance that this could cause actual issues.
lhotari
reviewed
Feb 6, 2026
Comment on lines
+104
to
+108
| readCurrentState(); | ||
| registerAsParticipant(); | ||
|
|
||
| // Watch for migration events | ||
| watchForMigrationEvents(); |
Member
There was a problem hiding this comment.
is there a chance that we lose an event between reading the current state and before the listener is registered?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implementation of PIP-454
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: