Skip to content

Conversation

bcaw-ofeer
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #1057

Brief Description

  1. Change MessageImpl.properties visibility from private to protected
  2. Modify getProperties() to return Collections.unmodifiableMap(properties) instead of new HashMap<>(properties)

This change enables:

  • Inheritance-based access to properties in subclasses
  • Immutable view of properties to prevent external modifications
  • Better performance by avoiding unnecessary HashMap allocations
  • Maintains backward compatibility while improving extensibility

lizhimins
lizhimins previously approved these changes Aug 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.40%. Comparing base (4076e2b) to head (48fd332).
⚠️ Report is 62 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1058      +/-   ##
============================================
+ Coverage     53.26%   53.40%   +0.13%     
- Complexity      651      689      +38     
============================================
  Files           208      211       +3     
  Lines         14303    14038     -265     
  Branches       5845     5532     -313     
============================================
- Hits           7619     7497     -122     
+ Misses         6308     6162     -146     
- Partials        376      379       +3     
Flag Coverage Δ
java 61.89% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bcaw-ofeer bcaw-ofeer requested a review from lizhimins August 5, 2025 11:51
lizhimins
lizhimins previously approved these changes Aug 11, 2025
@bcaw-ofeer bcaw-ofeer closed this Aug 28, 2025
@bcaw-ofeer bcaw-ofeer reopened this Aug 28, 2025
@lizhimins lizhimins merged commit 7389a30 into apache:master Sep 4, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants