-
Notifications
You must be signed in to change notification settings - Fork 279
[ISSUE #1152] [RIP-80] [Java] Implementation of Priority Message #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1153 +/- ##
============================================
+ Coverage 53.26% 53.43% +0.16%
- Complexity 651 751 +100
============================================
Files 208 216 +8
Lines 14303 14339 +36
Branches 5845 5567 -278
============================================
+ Hits 7619 7662 +43
+ Misses 6308 6276 -32
- Partials 376 401 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // Key(s) of the message, another way to mark message besides message id. | ||
| .setKeys("yourMessageKey") | ||
| // Set priority of message. | ||
| .setPriority(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the new feature to the capability set in readme.md
| public MessageViewImpl(MessageId messageId, String topic, byte[] body, String tag, | ||
| String messageGroup, String liteTopic, | ||
| Long deliveryTimestamp, Collection<String> keys, Map<String, String> properties, | ||
| Long deliveryTimestamp, Integer priority, Collection<String> keys, Map<String, String> properties, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new constructor should be added.
Change-Id: Ib4d1d67573948a5c66ec1e0c83082d2bfb44d9e6
Which Issue(s) This PR Fixes
#1152
Brief Description
How Did You Test This Change?