Skip to content

Conversation

@imzs
Copy link
Contributor

@imzs imzs commented Dec 16, 2025

Which Issue(s) This PR Fixes

#1152

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.43%. Comparing base (4076e2b) to head (e817802).
⚠️ Report is 84 commits behind head on master.

Files with missing lines Patch % Lines
...tmq/client/java/message/PublishingMessageImpl.java 0.00% 4 Missing and 4 partials ⚠️
...ache/rocketmq/client/java/message/MessageImpl.java 60.00% 2 Missing ⚠️
...ache/rocketmq/client/java/message/MessageType.java 33.33% 2 Missing ⚠️
.../rocketmq/client/java/message/MessageViewImpl.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1153      +/-   ##
============================================
+ Coverage     53.26%   53.43%   +0.16%     
- Complexity      651      751     +100     
============================================
  Files           208      216       +8     
  Lines         14303    14339      +36     
  Branches       5845     5567     -278     
============================================
+ Hits           7619     7662      +43     
+ Misses         6308     6276      -32     
- Partials        376      401      +25     
Flag Coverage Δ
java 61.40% <61.76%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lizhimins lizhimins changed the title [RIP-80] #1152 Implementation of Priority Message [ISSUE #1152] [RIP-80] [Java] Implementation of Priority Message Dec 29, 2025
// Key(s) of the message, another way to mark message besides message id.
.setKeys("yourMessageKey")
// Set priority of message.
.setPriority(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the new feature to the capability set in readme.md

public MessageViewImpl(MessageId messageId, String topic, byte[] body, String tag,
String messageGroup, String liteTopic,
Long deliveryTimestamp, Collection<String> keys, Map<String, String> properties,
Long deliveryTimestamp, Integer priority, Collection<String> keys, Map<String, String> properties,
Copy link
Member

@lizhimins lizhimins Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new constructor should be added.

Change-Id: Ib4d1d67573948a5c66ec1e0c83082d2bfb44d9e6
@lizhimins lizhimins merged commit 8903b2f into apache:master Dec 29, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants