Skip to content

[ISSUE #196] Fix serviceAccountName inconsistency #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[ISSUE #196] Fix serviceAccountName inconsistency #197

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d122732
fix: ServiceAccountName inconsistency
sinloss Dec 4, 2023
455530e
fix: ServiceAccountName inconsistency re deploy
sinloss Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/rocketmq-operator/templates/operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
labels:
name: rocketmq-operator
spec:
serviceAccountName: rocketmq-operator
serviceAccountName: {{ template "rocketmq-operator.serviceAccountName" . }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is copied from that one in deploy directory(see the link below), pls also change the original file.
https://github.com/apache/rocketmq-operator/blob/a8665716c8028741ec106814798e39fe07e6dcaa/Makefile#L78C1-L88

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll go through it once I have time. Please bear with me for a couple of days.

terminationGracePeriodSeconds: 10
containers:
- name: manager
Expand Down