Skip to content

[ISSUE #705] Fix future in async send not complete #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RongtongJin merged 1 commit into from
Feb 13, 2025
Merged

[ISSUE #705] Fix future in async send not complete #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ...ent-spring-boot/src/main/java/org/apache/rocketmq/client/core/RocketMQClientTemplate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,14 +315,24 @@ public CompletableFuture<SendReceipt> asyncSend(String destination, Message<?> m
throw new IllegalArgumentException("`message` and `message.payload` cannot be null");
}
Producer grpcProducer = this.getProducer();
CompletableFuture<SendReceipt> future0;
try {
org.apache.rocketmq.client.apis.message.Message rocketMsg = this.createRocketMQMessage(destination, message, messageDelayTime, messageGroup);
future = grpcProducer.sendAsync(rocketMsg);
future0 = grpcProducer.sendAsync(rocketMsg);
if (null != future) {
future0.whenComplete((sendReceipt, throwable) -> {
if (null != throwable) {
future.completeExceptionally(throwable);
} else {
future.complete(sendReceipt);
}
});
}
} catch (Exception e) {
log.error("send request message failed. destination:{}, message:{} ", destination, message);
throw new MessagingException(e.getMessage(), e);
}
return future;
return future0;
}

public Pair<SendReceipt, Transaction> sendMessageInTransaction(String destination, Object payload) throws ClientException {
Expand Down
Loading