[ISSUE #9735] Add TimerWheel snapshot mechanism for reliable recovery #9736
+268
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #9736 +/- ##
=============================================
- Coverage 48.36% 48.21% -0.16%
+ Complexity 12204 12178 -26
=============================================
Files 1313 1313
Lines 93340 93440 +100
Branches 11962 11982 +20
=============================================
- Hits 45148 45051 -97
- Misses 42627 42802 +175
- Partials 5565 5587 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guyinyou
force-pushed
the
dev_fix_timer_wheel_for_develop_000
branch
from
908f5ae to
bcd8268
Compare
guyinyou
force-pushed
the
dev_fix_timer_wheel_for_develop_000
branch
from
c4a54dd to
a2a3fe3
Compare
RongtongJin
reviewed
Oct 14, 2025
store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java
Outdated
Show resolved
Hide resolved
RongtongJin
previously approved these changes
Oct 14, 2025
guyinyou
force-pushed
the
dev_fix_timer_wheel_for_develop_000
branch
from
29f2234 to
23e30a1
Compare
- Add snapshot backup and recovery functionality to TimerWheel - Add configuration options for snapshot control with backward compatibility - Implement atomic flush operations with synchronization locks - Add snapshot file management (creation, cleanup, selection) - Support recovery from snapshot files to avoid rebuilding TimerWheel - Add TimerFlushService.flush() method for manual flush operations This addresses the issue where discrete TimerWheel state cannot be recovered from TimerLog alone, ensuring data consistency and improving recovery performance. Configuration changes: - timerWheelSnapshotFlush: enable/disable snapshot functionality (default: false) - timerWheelDefaultFlush: enable/disable default flush behavior (default: true) - timerWheelSnapshotIntervalMs: snapshot creation interval (default: 10s) Change-Id: I801ce7ca6330d02aefcae905e59e1e2b7642ebf5
Change-Id: I1c7c2895efebfef0185411c0630bbd2da23ce3c7
guyinyou
force-pushed
the
dev_fix_timer_wheel_for_develop_000
branch
from
23e30a1 to
98f73e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue where discrete TimerWheel state cannot be recovered from TimerLog alone, ensuring data consistency and improving recovery performance.
Configuration changes:
Change-Id: I801ce7ca6330d02aefcae905e59e1e2b7642ebf5
Which Issue(s) This PR Fixes
Fixes #9735
Brief Description
How Did You Test This Change?