Skip to content

[ISSUE #9737] Fix client memory leak on connection failure #9740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+18 −16
Open

[ISSUE #9737] Fix client memory leak on connection failure #9740

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a4e302
fix mem leak
qianye1001 Sep 26, 2025
ab90545
fix mem leak
qianye1001 Sep 28, 2025
0c64224
fix mem leak
qianye1001 Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ private ChannelFuture createChannelAsync(final String addr) throws InterruptedEx
if (cw.isOK() || !cw.getChannelFuture().isDone()) {
return cw.getChannelFuture();
} else {
this.channelWrapperTables.remove(cw.getChannel());
this.channelTables.remove(addr);
}
}
Expand All @@ -723,7 +724,10 @@ private ChannelWrapper createChannel(String addr) {
ChannelFuture channelFuture = doConnect(addr);
LOGGER.info("createChannel: begin to connect remote host[{}] asynchronously", addr);
ChannelWrapper cw = new ChannelWrapper(addr, channelFuture);
this.channelTables.put(addr, cw);
ChannelWrapper oldChannelWrapper = this.channelTables.put(addr, cw);
if (oldChannelWrapper != null) {
channelWrapperTables.remove(oldChannelWrapper.getChannel());
}
this.channelWrapperTables.put(channelFuture.channel(), cw);
return cw;
}
Expand Down
Loading