Skip to content

[ISSUE #9902] Remove unnecessary String.format #9903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yx9o wants to merge 1 commit into
base: develop
Choose a base branch
from
+27 −16
Open

[ISSUE #9902] Remove unnecessary String.format #9903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 27 additions & 16 deletions tools/src/main/java/org/apache/rocketmq/tools/monitor/DefaultMonitorListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,13 @@

package org.apache.rocketmq.tools.monitor;

import org.apache.rocketmq.logging.org.slf4j.Logger;
import org.apache.rocketmq.logging.org.slf4j.LoggerFactory;
import org.apache.rocketmq.remoting.protocol.body.ConsumerRunningInfo;

import java.util.Iterator;
import java.util.Map.Entry;
import java.util.TreeMap;
import org.apache.rocketmq.remoting.protocol.body.ConsumerRunningInfo;
import org.apache.rocketmq.logging.org.slf4j.Logger;
import org.apache.rocketmq.logging.org.slf4j.LoggerFactory;

public class DefaultMonitorListener implements MonitorListener {
private final static String LOG_PREFIX = "[MONITOR] ";
Expand All @@ -34,33 +35,43 @@ public DefaultMonitorListener() {

@Override
public void beginRound() {
logger.info(LOG_PREFIX + "=========================================beginRound");
logger.info("{}=========================================beginRound", LOG_PREFIX);
}

@Override
public void reportUndoneMsgs(UndoneMsgs undoneMsgs) {
logger.info(String.format(LOG_PREFIX + "reportUndoneMsgs: %s", undoneMsgs));
logger.info("{}reportUndoneMsgs: {}", LOG_PREFIX, undoneMsgs);
}

@Override
public void reportFailedMsgs(FailedMsgs failedMsgs) {
logger.info(String.format(LOG_PREFIX + "reportFailedMsgs: %s", failedMsgs));
logger.info("{}reportFailedMsgs: {}", LOG_PREFIX, failedMsgs);
}

@Override
public void reportDeleteMsgsEvent(DeleteMsgsEvent deleteMsgsEvent) {
logger.info(String.format(LOG_PREFIX + "reportDeleteMsgsEvent: %s", deleteMsgsEvent));
logger.info("{}reportDeleteMsgsEvent: {}", LOG_PREFIX, deleteMsgsEvent);
}

@Override
public void reportConsumerRunningInfo(TreeMap<String, ConsumerRunningInfo> criTable) {
if (criTable == null || criTable.isEmpty()) {
logger.warn("{}ConsumerRunningInfo is empty.", LOG_NOTIFY);
return;
}

ConsumerRunningInfo firstValue = criTable.firstEntry().getValue();
if (firstValue == null || firstValue.getProperties() == null) {
logger.warn("{}ConsumerRunningInfo entry is empty.", LOG_NOTIFY);
return;
}

String consumerGroup = firstValue.getProperties().getProperty("consumerGroup");

{
boolean result = ConsumerRunningInfo.analyzeSubscription(criTable);
if (!result) {
logger.info(String.format(LOG_NOTIFY
+ "reportConsumerRunningInfo: ConsumerGroup: %s, Subscription different", criTable
.firstEntry().getValue().getProperties().getProperty("consumerGroup")));
logger.info("{}reportConsumerRunningInfo: ConsumerGroup: {}, Subscription different", LOG_NOTIFY, consumerGroup);
}
}

Expand All @@ -70,18 +81,18 @@ public void reportConsumerRunningInfo(TreeMap<String, ConsumerRunningInfo> criTa
Entry<String, ConsumerRunningInfo> next = it.next();
String result = ConsumerRunningInfo.analyzeProcessQueue(next.getKey(), next.getValue());
if (!result.isEmpty()) {
logger.info(String.format(LOG_NOTIFY
+ "reportConsumerRunningInfo: ConsumerGroup: %s, ClientId: %s, %s",
criTable.firstEntry().getValue().getProperties().getProperty("consumerGroup"),
next.getKey(),
result));
logger.info("{}reportConsumerRunningInfo: ConsumerGroup: {}, ClientId: {}, {}",
LOG_NOTIFY,
consumerGroup,
next.getKey(),
result);
}
}
}
}

@Override
public void endRound() {
logger.info(LOG_PREFIX + "=========================================endRound");
logger.info("{}=========================================endRound", LOG_PREFIX);
}
}
Loading