[Fix][Connector-V2] Fix db2 table lower case bug #9568
Conversation
|
waiting test case passes. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the DB2 connector related to table field identifier handling and case sensitivity. The changes implement proper field identifier quoting and case-sensitive field handling for DB2 tables, particularly addressing issues with lowercase field names.
Key changes:
- Enhanced DB2Dialect class to support configurable field identifier handling with proper quoting
- Updated DB2DialectFactory to support field identifier configuration
- Modified test cases to include mixed-case field scenarios for validation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| DB2Dialect.java | Added field identifier handling, proper quoting methods, and enhanced upsert statement generation |
| DB2DialectFactory.java | Added overloaded create method to support field identifier configuration |
| JdbcDb2IT.java | Added test case with mixed-case field name "c_int_2" |
| jdbc_db2_source_and_sink.conf | Updated SQL query to include the new test field |
| sb.append("\"").append(parts[i]).append("\"").append("."); | ||
| } | ||
| return sb.append("\"") | ||
| .append(getFieldIde(parts[parts.length - 1], fieldIde)) |
There was a problem hiding this comment.
The method getFieldIde is called but not defined in this class. This will cause a compilation error.
Copilot uses AI. Check for mistakes.
| .append("\"") | ||
| .toString(); | ||
| } | ||
| return "\"" + getFieldIde(identifier, fieldIde) + "\""; |
There was a problem hiding this comment.
The method getFieldIde is called but not defined in this class. This will cause a compilation error.
Copilot uses AI. Check for mistakes.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide