[Fix][Core]fix kotlin jar conflict #9683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Zeta
Transform-v2
e2e
connectors-v2
druid
core
litiliu
changed the title
github-actions
bot
added
the
dependencies
litiliu
force-pushed
the
fix-9682
branch
4 times, most recently
from
eadedbf to
870ae05
Compare
litiliu
changed the title
litiliu
changed the title
Hisoka-X
reviewed
Aug 25, 2025
Comment on lines
50
to
55
| <exclusions> | ||
| <exclusion> | ||
| <groupId>com.squareup.okhttp</groupId> | ||
| <artifactId>okhttp</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
I'm a bit worried that this will cause potential anomalies in the hadoop uber jar.
There was a problem hiding this comment.
the support of okhttp 4.9.* only start from hadoop 3.4.0, 3.3.4 , the previous hadoop versions are using a pretty old version okhttp 2.7.5. see HDFS-16453
Would it be better to updating the hadoop version(3.1.4->3.4.1) and the okhttp(2.7.5->4.9) at the same PR?
There was a problem hiding this comment.
@Hisoka-X Could you please kindly give some advices here?
There was a problem hiding this comment.
How about update the hadoop version first?
litiliu
changed the title
|
@Hisoka-X Could you please review? Thanks! |
litiliu
changed the title
Hisoka-X
approved these changes
Aug 28, 2025
corgy-w
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #9682
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide