Skip to content

Alleviate the connection leak caused by Seata Client throwing exceptions in CONNECTION_STRICTLY connection mode#34498

Closed
linghengqian wants to merge 1 commit intoapache:masterfrom
linghengqian:fix-cluster
Closed

Alleviate the connection leak caused by Seata Client throwing exceptions in CONNECTION_STRICTLY connection mode#34498
linghengqian wants to merge 1 commit intoapache:masterfrom
linghengqian:fix-cluster

Conversation

@linghengqian
Copy link
Member

Fixes #34418 .

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

…ons in `CONNECTION_STRICTLY` connection mode
Copy link
Member Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Closing the current PR since the unit tests correctly assert this error.

@linghengqian linghengqian deleted the fix-cluster branch January 25, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

org.apache.shardingsphere.driver.jdbc.core.connection.DriverDatabaseConnectionManager#createConnections leaks connection if replay throws exception

1 participant