Include shell script in repo to start proxy container with local changes #34859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omkar-shitole
changed the title
linghengqian
reviewed
Apr 8, 2025
There was a problem hiding this comment.
This PR feels very subtle to me because you seem to assume that developers have installed the Docker Engine that supports Linux Containers.
At least on Windows Server 2025, users cannot run Linux Containers. And for Windows 11 and Windows Server 2025, they don't have bash.
From my perspective, the current PR direction is to create a new release Maven module instead of placing scripts in the root directory of git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support/FIX: Start the container instantly just by running
sh start.sh.Added a
start.shfile in the repo to help contributors/developers start a docker proxy container in a completely ready state.Before committing this PR, I'm sure that I have checked the following options:
Start the container including all the latest changes in the local repo. instantly just by running the start.sh script.