Remove P6spy module and related configurations from project files#35280
Merged
terrymanu merged 1 commit intoapache:masterfrom Apr 28, 2025
Merged
Remove P6spy module and related configurations from project files#35280terrymanu merged 1 commit intoapache:masterfrom
terrymanu merged 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the P6spy module and its related configurations from the project. The key changes include:
- Removal of the P6spy MySQL database type implementation.
- Removal of associated tests for P6spy.
- Removal of P6spy documentation (both English and Chinese versions).
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infra/database/type/p6spy/src/test/java/org/apache/shardingsphere/infra/database/p6spy/type/P6spyMySQLDatabaseTypeTest.java | Deleted tests for P6spy MySQL database type |
| infra/database/type/p6spy/src/main/java/org/apache/shardingsphere/infra/database/p6spy/type/P6spyMySQLDatabaseType.java | Deleted implementation of the P6spy MySQL database type |
| docs/document/content/user-manual/shardingsphere-jdbc/unsupported/p6spy/_index.en.md | Removed English documentation for P6spy |
| docs/document/content/user-manual/shardingsphere-jdbc/unsupported/p6spy/_index.cn.md | Removed Chinese documentation for P6spy |
Files not reviewed (5)
- infra/common/pom.xml: Language not supported
- infra/database/type/p6spy/pom.xml: Language not supported
- infra/database/type/p6spy/src/main/resources/META-INF/services/org.apache.shardingsphere.infra.database.core.type.DatabaseType: Language not supported
- infra/database/type/pom.xml: Language not supported
- infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.shardingsphere/generated-reachability-metadata/reflect-config.json: Language not supported
taojintianxia
approved these changes
Apr 28, 2025
iamhucong
pushed a commit
to iamhucong/shardingsphere
that referenced
this pull request
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35279.