[Part 1] Add ParameterFilterable interface #37255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fottas
changed the title
Fottas
changed the title
terrymanu
requested changes
Dec 2, 2025
Member
terrymanu
left a comment
terrymanu
left a comment
There was a problem hiding this comment.
Right now the changes are spread across multiple PRs, which makes it hard to assess the overall design and impact. Please consolidate the main code into a single, complete PR so we can review the design, code, and tests together. Otherwise, each fragmented PR lacks context and cannot be merged.
Member
|
Closed because of no response anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is the first PR for the IN predicate optimization feature, introducing the foundational interface for parameter filtering.
Changes
Add ParameterFilterable interface to define parameter filtering capability
Provide getRemovedParameterIndices(RouteUnit) method to declare parameter indices that should be removed
Provide isParameterFilterable() default method to allow conditional filtering enablement
Design Rationale
Interface is placed in infra.rewrite.core module as a generic extension point for the rewrite engine
Currently designed specifically for sharding IN optimization; may potentially support other parameter filtering scenarios in the future if such needs arise
Fully backward compatible - does not affect existing token generators
Related Issue
Part of #36454 (1)
Next Steps
The next PR will integrate parameter filtering logic into RouteSQLRewriteEngine.