Skip to content

Conversation

@menghaoranss
Copy link
Contributor

Fixes #ISSUSE_ID.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds comprehensive test cases for the Hive SQL parser, expanding test coverage for both SELECT and INSERT operations. The PR introduces 19 SELECT test cases and 5 INSERT test cases with corresponding assertion files that validate parser behavior against expected parse tree structures.

  • Adds test coverage for basic and advanced Hive SQL features including JOINs, window functions, subqueries, and partitioning
  • Implements detailed parse tree assertions with precise character index positions for each SQL construct
  • Extends the existing test framework with Hive-specific DML statement tests

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
test/it/parser/src/main/resources/sql/supported/dml/select-hive.xml Defines 19 SQL test cases covering SELECT operations including simple queries, WHERE clauses, GROUP BY/HAVING, ORDER BY, LIMIT/OFFSET, various JOIN types, UNIONs, DISTINCT, window functions, subqueries, and string/date functions
test/it/parser/src/main/resources/sql/supported/dml/insert-hive.xml Defines 5 SQL test cases covering INSERT operations including basic INSERT INTO/VALUES, INSERT OVERWRITE, partition inserts, and FROM clause inserts
test/it/parser/src/main/resources/case/dml/select-hive.xml Contains detailed parse tree assertions for all 19 SELECT test cases, specifying exact character positions for projections, tables, clauses, and expressions
test/it/parser/src/main/resources/case/dml/insert-hive.xml Contains detailed parse tree assertions for all 5 INSERT test cases, specifying exact character positions for table names, columns, and values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@terrymanu terrymanu merged commit feb0319 into apache:master Jan 7, 2026
20 checks passed
@menghaoranss menghaoranss deleted the dev branch January 7, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants