Remove support for DerbyNetworkServer and EmbeddedDerby#37718
Merged
sandynz merged 1 commit intoapache:masterfrom Jan 13, 2026
Merged
Remove support for DerbyNetworkServer and EmbeddedDerby#37718sandynz merged 1 commit intoapache:masterfrom
sandynz merged 1 commit intoapache:masterfrom
Conversation
linghengqian
force-pushed
the
rm-db
branch
3 times, most recently
from
420d494 to
c89b9eb
Compare
linghengqian
force-pushed
the
rm-db
branch
4 times, most recently
from
572c025 to
acafff0
Compare
7 tasks
There was a problem hiding this comment.
Pull request overview
This PR removes support for Derby databases (both DerbyNetworkServer and EmbeddedDerby) from the ShardingSphere standalone JDBC repository provider, as requested in issue #37500. The removal is clean and comprehensive.
Changes:
- Removed test assertions for DerbyNetworkServer and EmbeddedDerby from JDBCRepositorySQLLoaderTest
- Deleted SQL configuration files for both Derby variants (EmbeddedDerby.xml and DerbyNetworkServer.xml)
- Removed GraalVM native-image reachability metadata entries for the deleted Derby configuration files
- Updated both English and Chinese documentation to remove Derby-related configuration examples and provider options
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mode/type/standalone/repository/provider/jdbc/src/test/java/.../JDBCRepositorySQLLoaderTest.java | Removed test assertions for EmbeddedDerby and DerbyNetworkServer |
| mode/type/standalone/repository/provider/jdbc/src/main/resources/sql/EmbeddedDerby.xml | Deleted Derby embedded database SQL configuration |
| mode/type/standalone/repository/provider/jdbc/src/main/resources/sql/DerbyNetworkServer.xml | Deleted Derby network server SQL configuration |
| infra/reachability-metadata/.../reachability-metadata.json | Removed GraalVM metadata entries for Derby XML files |
| docs/document/content/user-manual/common-config/builtin-algorithm/metadata-repository.en.md | Updated English documentation to remove Derby references and examples |
| docs/document/content/user-manual/common-config/builtin-algorithm/metadata-repository.cn.md | Updated Chinese documentation to remove Derby references and examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sandynz
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37500 .
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.