Add support for PostgreSQL version() in SQL federation#38564
Draft
somiljain2006 wants to merge 8 commits intoapache:masterfrom
Draft
Add support for PostgreSQL version() in SQL federation#38564somiljain2006 wants to merge 8 commits intoapache:masterfrom
somiljain2006 wants to merge 8 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@terrymanu @menghaoranss @taojintianxia @RaigorJiang @strongduanmu @FlyingZC Can you please review this pr? |
Member
|
Hi @somiljain2006, can you add e2e test in db_tbl_sql_federation scenario? |
Contributor
Author
|
I think there is some problem with my logic, as after running the e2e test, it shows errors so therefore im marking this pr as draft till i came up with my new logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37436
Changes proposed in this pull request:
How was this tested?
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.